Skip to content

Use the SDK's one destructive declaration and guard; drop MICROSOFT_ALLOW_DESTRUCTIVE (requires scion-sdk 0.10.2) - #39

Merged
Knucklessg1 merged 2 commits into
mainfrom
feat/microsoft-standard-destructive
Nov 12, 2026
Merged

Knucklessg1 merged 2 commits into
mainfrom
feat/microsoft-standard-destructive

Conversation

@Knucklessg1

Copy link
Copy Markdown
Member

What

Destructive operations are declared with the SDK and decided by its guard. The MICROSOFT_ALLOW_DESTRUCTIVE setting and the destructive_action_acknowledged field of the Intune confirmation evidence are removed. Eleven Graph client methods the SDK would not classify carry destructive_operation; the Intune reboot and shutdown, desktop-flow cancellation, PowerPoint slide deletion and destructive Windows companion actions run guard_destructive. Each served tool has the MCP destructive hint and the standard confirm argument. MICROSOFT_ALLOW_WRITES stays as deployment access scope.

Why

An agent must not be able to self-authorize a destructive call: the gateway asks a human to approve a call classified by the hint, clients that cannot be asked pass confirm, and unattended operation uses the single operator setting SCION_ALLOW_DESTRUCTIVE.

Impact

MICROSOFT_ALLOW_DESTRUCTIVE is no longer read; callers pass confirm or are confirmed by the gateway. Requires scion-sdk 0.10.2.

Verification

52 targeted tests pass, including a served check that every destructive tool has the hint and a confirm argument and no allow argument, and a refusal check that sends no request.

Spec: CONN-MICROSOFT-AGENT-CONNECTOR-CONTENT-R002 (destructive operations use the SDK declaration and guard)

🤖 Generated with Claude Code

Destructive Microsoft operations had their own gate: a MICROSOFT_ALLOW_DESTRUCTIVE
setting checked by the tool policy and the Windows companion tool, and a
destructive_action_acknowledged field in the Intune confirmation evidence. That
gate is removed. Eleven Graph client methods the SDK would not classify
(application passwords, service principals, role assignments, conditional access,
organization and admin SharePoint updates, risky-user dismissal, device wipe and
retire) carry the SDK declaration, and the hand-written destructive tools
(Intune reboot and shutdown, desktop-flow cancellation, PowerPoint slide
deletion, Windows companion actions) run the SDK guard. Each served tool has the
MCP destructive hint and the standard confirm argument; a call without a live
confirmation makes no request. MICROSOFT_ALLOW_WRITES stays as deployment access
scope. The single operator setting for unattended use is SCION_ALLOW_DESTRUCTIVE.
Requires scion-sdk 0.10.2.

Impact: MICROSOFT_ALLOW_DESTRUCTIVE is no longer read; callers pass confirm (or are
confirmed by the gateway); Intune evidence no longer carries an acknowledgement
field.

Verification: 52 targeted tests pass, including a served check of the hint and
confirm argument on every destructive tool and a refusal check that sends no request.

Spec: CONN-MICROSOFT-AGENT-CONNECTOR-CONTENT-R002 (destructive operations use the SDK declaration and guard)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Knucklessg1
Knucklessg1 force-pushed the feat/microsoft-standard-destructive branch from 53694da to db29a6b Compare November 12, 2026 19:53
Message and Event now extend core DomainEntity and File extends core Artifact so
the connector-surface ontology check passes.

Spec: none (class roll-up to the core ontology; no new requirement)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Knucklessg1
Knucklessg1 merged commit 2e43b82 into main Nov 12, 2026
14 checks passed
@Knucklessg1

Copy link
Copy Markdown
Member Author

Pre-merge test run: PASSED

What this is: the full test and lint suite of this repository, run before merge on the tested tree below, because the hosted checks are not the gate for this change. Impact: the change is cleared to merge.

Tested tree: the pull request head bec0128bfd86. Diff range b4fabfbc6aba..bec0128bfd86. CI shape read from .github/workflows/connector.yml: config .pre-commit-config.yaml, stages pre-commit.

Check Ran on Result Time
pre-commit (light hooks) local machine ok: 12 hook runs over pre-commit 24s
tests (pytest -q tests, full suite) separate build machine ok: 374 passed, 37 warnings in 23.44s 31s

Total time 2m19s. Verification: each check above was run on the tested tree and the result is the exit status of the repository's own commands.

@Knucklessg1
Knucklessg1 deleted the feat/microsoft-standard-destructive branch November 12, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant